Remove copy on write for mpt_insert and mpt_delete #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborgeaud
approved these changes
Aug 19, 2023
Comment on lines
36
to
37
| %stack (first_nibble, node_payload_ptr, retdest) -> (node_payload_ptr, retdest) | ||
| PUSH 1 SWAP1 SUB |
There was a problem hiding this comment.
nit: Either
%stack (first_nibble, node_payload_ptr, retdest) -> (node_payload_ptr, 1, retdest)
SUB
or
%stack (first_nibble, node_payload_ptr, retdest) -> (node_payload_ptr, retdest)
%sub_const(1) // or %decrement
would be a tad cleaner imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with removing the copy-on-write logic in MPT insertion and deletion, as mentioned in this PR.
When testing on
test_simple_transfer, we observe a reduction of the number of rows in a couple of STARKs, fromTraceCheckpoint { arithmetic_len: 10288, cpu_len: 77254, keccak_len: 463, keccak_sponge_len: 26, logic_len: 3347, memory_len: 467164 }in main, to:
TraceCheckpoint { arithmetic_len: 10288, cpu_len: 77108, keccak_len: 453, keccak_sponge_len: 26, logic_len: 3297, memory_len: 465103 }with this optimization.
Most of the time, when there was a change of node type, I left a new node creation as I feared using the same node pointer would lead to overwritten data while updating the node. (It was generally easier to do in MPT deletion cases though).
@wborgeaud Please let me know if I forgot cases, or if there's anything I can improve/need to change!