Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2 limbs for BlockBaseFee #1194

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Aug 19, 2023

Allows BlockBaseFee to be greater than 32 bits, following discussion in #1193.

@wborgeaud: the actual changes are in the first commit. The second one deals with code duplication removal and moves the get_memory_extra_looking_products_circuit method to recursive_verifier.rs where I think it should belong (based on where the other "circuit-version" verification methods are implemented).

@Nashtare Nashtare self-assigned this Aug 19, 2023
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Nashtare Nashtare merged commit a94d928 into 0xPolygonZero:main Aug 19, 2023
2 checks passed
@Nashtare Nashtare deleted the block_basefee branch August 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants