Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gas update #16

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix gas update #16

merged 1 commit into from
Jan 26, 2024

Conversation

Nashtare
Copy link
Contributor

@Nashtare Nashtare commented Jan 26, 2024 •
edited
Loading

The gas_used_after accumulator wasn't accumulating the current txn gas_used, but being reset instead, causing gas check failures post first txn of a block.

@Nashtare Nashtare added the bug Something isn't working label Jan 26, 2024
@Nashtare Nashtare requested a review from BGluth January 26, 2024 16:54
@Nashtare Nashtare self-assigned this Jan 26, 2024
BGluth
BGluth approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@BGluth BGluth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good!

@Nashtare Nashtare merged commit a995c6e into 0xPolygonZero:main Jan 26, 2024
2 checks passed
@Nashtare Nashtare deleted the fix_gas branch January 26, 2024 17:03
@dvdplm
Copy link
Contributor

dvdplm commented Jan 26, 2024

Love me a one char fix like these! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BGluth BGluth BGluth approved these changes

Assignees

@Nashtare Nashtare

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashtare @dvdplm @BGluth