Fix padding for single txn blocks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGluth
approved these changes
Jan 30, 2024
dvdplm
approved these changes
Jan 30, 2024
| // after the only txn of this block. | ||
| // If there are no withdrawals, then the dummy proof will be prepended to the | ||
| // actual txn. | ||
| match has_withdrawals { |
There was a problem hiding this comment.
Why not use if { … } else { … }?
There was a problem hiding this comment.
I actually find that using a match on a bool is usually more readable (there might be something wrong with me, idk 🙃) than an if / else. I think using a match is a bit less common though.
There was a problem hiding this comment.
Yeah not sure why I went for match, maybe an implicit preference as Brendan said, happy to change though
muursh
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still prepending to the actual txn the dummy payload for blocks containing only 1 txn, but we were then updating that payload if the block contained withdrawals.
We now do a case disjunction for single_txn blocks based on the presence of withdrawals: