This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: implement concurrent block proving #88 #89 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xaatif
approved these changes
Jun 5, 2024
Co-authored-by: 0xaatif <[email protected]>
Nashtare
approved these changes
Jun 5, 2024
muursh
approved these changes
Jun 5, 2024
atanmarko
added a commit
that referenced
this pull request
Jun 10, 2024
* feat: add block interval * fix: follow from loop * feat: add block hash parsing for interval * fix: proving logic * fix: typos * fix: review * fix: doc tests * feat: add block time cli argument * fix: interval display * feat: add from string for block interval * fix: remove block interval single variant * feat: implement concurrent block proving #88 #89 (#96) * feat: implement concurrent block proving #88 #89 * Update prover/src/lib.rs Co-authored-by: 0xaatif <[email protected]> * fix suggestion * Fix duplicated import when #[cfg(feature = "test_only")] --------- Co-authored-by: 0xaatif <[email protected]> Co-authored-by: Marko Atanasievski <[email protected]> * fix: block interval fmt * fix: make parsing functions private * fix: use futures iterator instead of tokio-stream * fix: use anyhow error instead of block interval error --------- Co-authored-by: Zach Brown <[email protected]> Co-authored-by: 0xaatif <[email protected]>
This was referenced Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept, closes #88 #89.
Proofs are communicated with a
oneshot::channel, avoiding any intermediate data structures or locking primitives (RE #90 (comment)).