Allow features with macros within macros (#492)

0xPolygonZero · Aug 14, 2024 · 0c2e771 · 0c2e771
1 parent c6d015b
commit 0c2e771
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/evm_arithmetization/src/cpu/kernel/assembler.rs b/evm_arithmetization/src/cpu/kernel/assembler.rs
@@ -219,6 +219,9 @@ fn expand_macros(
                     expanded.extend(expand_macros(body.clone(), macros, macro_counter));
                 }
             }
+            Item::ConditionalBlock(_, items) => {
+                expanded.extend(expand_macros(items.clone(), macros, macro_counter));
+            }
             item => {
                 expanded.push(item);
             }

diff --git a/evm_arithmetization/src/cpu/kernel/parser.rs b/evm_arithmetization/src/cpu/kernel/parser.rs
@@ -246,6 +246,14 @@ mod tests {
     #[test]
     fn test_feature() {
         let code = r#"
+        %macro bar_foo
+            #[cfg(feature = feature_1)]
+            {
+                %bar
+                PUSH 3
+                ADD
+            }
+        %endmacro
         #[cfg(feature = feature_1)]
         {
             %macro bar
@@ -260,7 +268,7 @@ mod tests {
 
             #[cfg(feature = feature_1)]
             {
-                %bar
+                %bar_foo
                 PUSH 1
             }
             PUSH 3
@@ -291,6 +299,8 @@ mod tests {
         %macro bar
             PUSH 2
             MUL
+            PUSH 3
+            ADD
         %endmacro
 
         global foo_1:
@@ -353,6 +363,8 @@ mod tests {
         %macro bar
             PUSH 2
             MUL
+            PUSH 3
+            ADD
         %endmacro
 
         global foo_1: