Apply review

evm_arithmetization/src/cpu/kernel/asm/cdk_pre_execution.asm

@@ -50,6 +50,9 @@ global update_scalable_prev_block_root_hash:
     %write_scalable_storage
     // stack: retdest
 
+// Note: We assume that if the l1 info tree has been re-used or the GER does not exist,
+// the payload will not contain any root to store, in which case calling `PROVER_INPUT(ger)`
+// will return `U256::MAX` causing this to return early.
 global update_scalable_l1blockhash:
     // stack: retdest
     PROVER_INPUT(ger)

evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/linked_list.asm

@@ -861,7 +861,7 @@ remove_all_slots_end:
     %slot_to_storage_key
     %address
     %addr_to_state_key
-    %stack (addr_key, key) -> (addr_key, key, 0, %%after)
+    %stack (addr_key, storage_key) -> (addr_key, storage_key, 0, %%after)
     %jump(search_slot)
 %%after:
     // stack: slot_value
@@ -870,9 +870,9 @@ remove_all_slots_end:
 %macro read_storage_linked_list_w_addr
     // stack: slot, address
     %slot_to_storage_key
-    SWAP1
+    %stack (address, storage_key) -> (address, storage_key, 0, %%after)
     %addr_to_state_key
-    %stack (addr_key, key) -> (addr_key, key, 0, %%after)
+    // stack: addr_key, storage_key, 0, %%after
     %jump(search_slot)
 %%after:
     // stack: slot_value
@@ -881,8 +881,7 @@ remove_all_slots_end:
 %macro read_storage_linked_list_w_state_key
     // stack: slot, state_key
     %slot_to_storage_key
-    SWAP1
-    %stack (state_key, key) -> (state_key, key, 0, %%after)
+    %stack (storage_key, state_key) -> (state_key, storage_key, 0, %%after)
     %jump(search_slot)
 %%after:
     // stack: slot_ptr

evm_arithmetization/src/generation/mod.rs

@@ -99,7 +99,7 @@ pub struct GenerationInputs {
     /// hashes.
     pub block_hashes: BlockHashes,
 
-    /// The the global exit root along with the l1blockhash to write to the GER
+    /// The global exit root along with the l1blockhash to write to the GER
     /// manager.
     ///
     /// This is specific to `cdk-erigon`.