Comment

0xPolygonZero · Sep 24, 2024 · a341c4f · a341c4f
1 parent 823007d
commit a341c4f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/evm_arithmetization/src/fixed_recursive_verifier.rs b/evm_arithmetization/src/fixed_recursive_verifier.rs
@@ -108,6 +108,10 @@ where
     pub by_table: [RecursiveCircuitsForTable<F, C, D>; NUM_TABLES],
 }
 
+// TODO(Robin): This should be refactored in two distinct states, chain-specific
+// (i.e. current `AllRecursiveCircuits` up to block circuit), and cross-chain
+// specific (the 2-to-1 aggregation piece).
+// cf: https://github.com/0xPolygonZero/zk_evm/issues/622
 pub struct AllVerifierData<F, C, const D: usize>
 where
     F: RichField + Extendable<D>,

diff --git a/zero/src/bin/aggregator.rs b/zero/src/bin/aggregator.rs
@@ -88,8 +88,8 @@ async fn main() -> Result<()> {
                 stdio::stdio_aggregate(runtime, Arc::new(prover_config)).await?
             }
         }
-        Command::Rpc {} => todo!(),
-        Command::Http {} => todo!(),
+        Command::Rpc {} => todo!(), // TODO(Robin): Do we want to support RPC input source?
+        Command::Http {} => todo!(), // TODO(Robin): Do we want to support RPC input source?
     }
 
     Ok(())

diff --git a/zero/src/bin/aggregator/stdio.rs b/zero/src/bin/aggregator/stdio.rs
@@ -10,7 +10,8 @@ use zero::{
     prover::ProverConfig,
 };
 
-/// The main function for the stdio mode.
+// TODO(Robin): This should probably live in `leader` binary
+/// Wrapping function for the stdio mode.
 pub(crate) async fn stdio_wrap(
     runtime: Arc<Runtime>,
     prover_config: Arc<ProverConfig>,
@@ -65,7 +66,7 @@ pub(crate) async fn stdio_wrap(
     Ok(())
 }
 
-/// The main function for the stdio mode.
+/// Aggregation function for the stdio mode.
 pub(crate) async fn stdio_aggregate(
     runtime: Arc<Runtime>,
     prover_config: Arc<ProverConfig>,