Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(zero-bin): Inconsistent async failures on block batches #354

Closed
Nashtare opened this issue Jul 2, 2024 · 5 comments
Closed

bug(zero-bin): Inconsistent async failures on block batches #354

Nashtare opened this issue Jul 2, 2024 · 5 comments
Assignees
Labels
bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates.
Milestone

Comments

@Nashtare
Copy link
Collaborator

Nashtare commented Jul 2, 2024

When proving batches of blocks (size 10), I got several issues with output as follows:

Error: Failed to send proof

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: <futures_util::future::future::flatten::Flatten<Fut,<Fut as core::future::future::Future>::Output> as core::future::future::Future>::poll
   2: <futures_util::future::future::Then<Fut1,Fut2,F> as core::future::future::Future>::poll
   3: <S as futures_core::stream::TryStream>::try_poll_next
   4: <futures_util::stream::try_stream::try_collect::TryCollect<St,C> as core::future::future::Future>::poll
   5: prover::ProverInput::prove::{{closure}}
   6: leader::client::client_main::{{closure}}
   7: leader::main::{{closure}}
   8: tokio::runtime::park::CachedParkThread::block_on
   9: tokio::runtime::context::runtime::enter_runtime
  10: tokio::runtime::runtime::Runtime::block_on
  11: leader::main
  12: std::sys_common::backtrace::__rust_begin_short_backtrace
  13: std::rt::lang_start::{{closure}}
  14: std::rt::lang_start_internal
  15: main
  16: <unknown>
  17: __libc_start_main
  18: _start

The errors are inconsistent between runs, but we should add some strengthening mechanism (with possibly some retry-upon-error kind of behavior), to prevent this.

I've been running as follows:

for n in {20175010..20180000..10}
do
    ./prove_rpc.sh $n $((n+9)) endpoint native true 1000 1000 test_only
done

(note that these block ranges are past Cancun upgrade, they have been ran against fix/native_cancun branch)

@Nashtare Nashtare added bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates. labels Jul 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Jul 2, 2024
@atanmarko
Copy link
Member

Fixed with increasing the ulimit: ulimit -n 4096

@github-project-automation github-project-automation bot moved this from Backlog to Done in Zero EVM Jul 3, 2024
@Nashtare Nashtare reopened this Jul 3, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Zero EVM Jul 3, 2024
@Nashtare
Copy link
Collaborator Author

Nashtare commented Jul 3, 2024

Seems there are still some sporadic issues with even ulimit -n 16384.

Ran with for n in {20175180..20180000..10}; do time ./prove_rpc.sh $n $((n+9)) rpc_url native true 1000 1000 test_only; done

@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jul 8, 2024
@BGluth
Copy link
Contributor

BGluth commented Jul 8, 2024

Maybe this is a bit of an aside, but I'll bet that the error:

Error: Failed to send proof

is probably an anyhow Result and that only the most recent context is getting printed and not the other contexts that are added as it calls down the stack. Probably with the rest of the contexts it might have given more of a hint that we were running out of file descriptors.

@atanmarko atanmarko self-assigned this Jul 8, 2024
@atanmarko
Copy link
Member

I will look into this in more depth soon

@atanmarko
Copy link
Member

Fixed with #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

No branches or pull requests

3 participants