Now warns if file descriptor limit is too small for native mode #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: zero_bin
Nashtare
reviewed
Jul 19, 2024
zero_bin/tools/prove_rpc.sh
Outdated
| @@ -60,6 +60,9 @@ OUTPUT_TO_TERMINAL="${OUTPUT_TO_TERMINAL:-false}" | |||
| # Only generate proof by default | |||
| RUN_VERIFICATION="${RUN_VERIFICATION:-false}" | |||
|
|
|||
| # Recommended soft file handle limit. Will warn if it is set lower. | |||
| RECOMMENDED_FILE_HANDLE_LIMIT=4096 | |||
There was a problem hiding this comment.
I would actually recommend 8192
zero_bin/tools/prove_rpc.sh
Outdated
| echo "WARNING: Maximum file descriptor limit may be too low to run native mode (current: $file_desc_limit, Recommended: ${RECOMMENDED_FILE_HANDLE_LIMIT}). | ||
| Consider increasing it with: | ||
|
|
||
| ulimit -s ${RECOMMENDED_FILE_HANDLE_LIMIT}" |
There was a problem hiding this comment.
Isn't -s only updating the stack size, as opposed to ulimit -n which updates the maximum number of open file descriptors?
There was a problem hiding this comment.
Ahh, good catch! Not sure how that got swapped with -s.
I think that should remain a user responsibility, we shouldn't expect the code to modify it arbitrarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just prints out a warning in
prove_rpc.shif the user has a file descriptor limit that is deemed too small when they are running in native mode. Does not attempt to change the limit (should we? We don't need root for this).If the limit is too small, then there's a good chance that we'll get various IO errors related to this with
nativemode. (#354 )