Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trie_diff tool to show all the differences in the tries #636

Closed
atanmarko opened this issue Sep 18, 2024 · 1 comment · Fixed by #655
Closed

Update trie_diff tool to show all the differences in the tries #636

atanmarko opened this issue Sep 18, 2024 · 1 comment · Fixed by #655
Assignees
@atanmarko
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Milestone
Testing and Valid...

Comments

@atanmarko
Copy link
Member

Currently it uses create_diff_between_tries which stops on the first difference.
@atanmarko atanmarko added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 18, 2024
@atanmarko atanmarko added this to the Testing and Validation milestone Sep 18, 2024
@atanmarko atanmarko self-assigned this Sep 18, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Sep 18, 2024
@BGluth
Copy link
Contributor

BGluth commented Sep 19, 2024

Just to clarify, if you do this for the top-down approach, be careful about continuing to search downwards for differences if you find a structural difference. In some cases this is fine (eg. a branch node is missing a child), but this is going to produce a ton of redundant output if the node type changes (eg. a branch becomes an extension).

@atanmarko atanmarko moved this from Backlog to In Progress in Zero EVM Sep 23, 2024
@atanmarko atanmarko mentioned this issue Sep 24, 2024
Merged
@atanmarko atanmarko moved this from In Progress to Ready to Review in Zero EVM Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in Zero EVM Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atanmarko atanmarko

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging a pull request may close this issue.

feat: trie multi diff comparison 0xPolygonZero/zk_evm
2 participants
@BGluth @atanmarko