-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trie multi diff comparison #655
Conversation
278b7f1
to
8473d71
Compare
8473d71
to
3904088
Compare
4db375a
to
793a081
Compare
793a081
to
40ebddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marko, I tested it and it does work fine. I think we'd need to limit the search to a certain number of discrepancies, possibly stopping early, displaying the result, along with some warn!("Too many differences, search aborted early.")
kinda message to hint that this may not be a good starting point.
One thing I forgot to mention, though technically orthogonal to this as part of the initial PR on trie-diff. If for a given state key, we have Leaf vs Branch, we'll stop at this level. It could be nice to go down the branch in the given trie, until we hit Leaf / Hash / Empty to try displaying the account diff (if any). The |
@Nashtare Ok, probably worth another PR to set it up. EDIT: problem with this is - what if the branch is big and has many paths down? What should be shown? Probably only general solution is to show one leaf and other branch as the point of difference. |
You have the state key, so can go down the branch children until you hit a final node |
c5b0bd7
to
916d298
Compare
Here is the new ticket #703 |
Resolves #636