Merge develop into feat/continuations
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overhaul leader CLI such that flags are grouped by subcommand
* Add LogicColumnsView struct * Add generate-evaluate test for logic stark * Add comments to gen-eval test in logic stark
github-actions
bot
added
crate: trace_decoder
muursh
approved these changes
Jul 3, 2024
Nashtare
reviewed
Jul 3, 2024
Nashtare
reviewed
Jul 4, 2024
zero_bin/ops/src/lib.rs
Outdated
| .map_err(|err| { | ||
| if let Err(write_err) = save_inputs_to_disk( | ||
| format!( | ||
| "b{}_txn_{}_input.log", |
There was a problem hiding this comment.
same here, we'd be writing the input of a segment upon error, so would need to specify the index
zero_bin/ops/src/lib.rs
Outdated
Comment on lines
126
to
130
| "{:x?}", | ||
| ir.signed_txns | ||
| .iter() | ||
| .map(|txn| keccak(txn.clone())) | ||
| .collect::<Vec<_>>() |
There was a problem hiding this comment.
nit: this is possibly huge, perhaps we could just print the hexadecimal start (say 8 chars) of the first & last txns of the batch?
* mark: 0xaatif/docker * run: docker init * run: rm compose.yaml * refactor: docker builds * feat: smoke test executables * refactor(ci): use new docker file * feat: xargs --verbose * refactor: one image * fix: one image * wibble: change id meta_leader -> meta * fix: censor minor version * fix: restore target-cpu=native
Nashtare
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges develop into
feat/continuations.Note that
prove_all_segmentsused to not return any proofs ifgenerate_next_segmentfailed due to aKernelPanic. I changed this so thatgenerate_next_segmentthrows apanic!when the interpreter returns an error.