Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditional feature support in the kernel assembly #416

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Jul 20, 2024

closes #409

I ended up using a more general approach to handle arbitrary chunks of code within conditional blocks (initial description in #409 was only mentioning skipping code between two global labels, not it handles arbitrary chunks).

Now anything between:

#[cfg(feature = feature_foo)]
{
    ....
}

will be ignored.

@Nashtare Nashtare added enhancement New feature or request crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Jul 20, 2024
@Nashtare Nashtare self-assigned this Jul 20, 2024
@Nashtare Nashtare requested a review from muursh as a code owner July 20, 2024 14:11
@Nashtare Nashtare added this to the System strengthening milestone Jul 21, 2024
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

evm_arithmetization/src/cpu/kernel/ast.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare merged commit 7a29b13 into develop Jul 23, 2024
14 checks passed
@Nashtare Nashtare deleted the feat/kernel_feature branch July 23, 2024 21:23
Nashtare added a commit that referenced this pull request Aug 31, 2024
* feat: add conditional feature support in the kernel

* Clippy

* Never enough clippy

* Wording

* Update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support conditional asm code parsing in the kernel
3 participants