feat: reorganize cli params #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: zero_bin
Nashtare
approved these changes
Jul 23, 2024
| @@ -20,9 +22,11 @@ use tracing::info; | |||
| use zero_bin_common::fs::generate_block_proof_file_name; | |||
|
|
|||
| #[derive(Debug, Clone, Copy)] | |||
| pub struct ProverParams { | |||
| pub struct ProverConfig { | |||
There was a problem hiding this comment.
Do we actually need to have a ProverConfig anymore, given that it is semantically identical to CliProverConfig, and that all fields are guaranteed to be initialized?
There was a problem hiding this comment.
@Nashtare I don't much like the idea of clap structure (CliProverConfig) being passed as an argument deep in the stack, but yeah, we can remove ProverConfig.
There was a problem hiding this comment.
Yeah I guessed you'd answer something along these lines 🙃
I'm not strongly opinionated, we can keep the distinction.
atanmarko
force-pushed
the
feat/reortanize-cli-params
branch
from
387c328
to
098fe75
Compare
atanmarko
merged commit e09916f
into
feat/optimize-segment-proof-aggregation
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #426