feat(continuations): write storage values directly in linked lists #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…45336afd not found in linked list
…ert_storage_change
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
changed the title
Nashtare
reviewed
Jul 24, 2024
4l0n50
approved these changes
Jul 29, 2024
| @@ -165,6 +165,10 @@ global perform_final_checks: | |||
| PROVER_INPUT(trie_ptr::state) | |||
|
|
|||
| %mstore_global_metadata(@GLOBAL_METADATA_STATE_TRIE_ROOT) | |||
|
|
|||
| PROVER_INPUT(trie_ptr::trie_data_size) | |||
| %mstore_global_metadata(@GLOBAL_METADATA_TRIE_DATA_SIZE) | |||
There was a problem hiding this comment.
Maybe this needs a comment saying that is not unsound to simply guess the size. I think it's because the values in the storage linked lists are already non det. advice, so it doesn't matter from where you are reading them.
hratoanina
approved these changes
Aug 2, 2024
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/initial_tries.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/initial_tries.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/initial_tries.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/linked_list.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/linked_list.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/mpt/linked_list/linked_list.asm
Outdated
Show resolved
Hide resolved
Nashtare
added a commit
that referenced
this pull request
Aug 6, 2024
) * Remove unnecessary linked_lists methods and payload_ptr * Store storage value in linked list * Fix Clippy and cleanup * Apply comments * Only write to TrieData if value nonzero * Fix comments and name changed in merge * Apply comments --------- Co-authored-by: 4l0n50 <[email protected]> Co-authored-by: Alonso Gonzalez <[email protected]> Co-authored-by: Robin Salen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398 .
This PR makes linked lists store the slot values directly, instead of a pointer to the
TrieDataSegment.