Remove self destructs from the native tracer #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
4l0n50
changed the title
muursh
approved these changes
Aug 6, 2024
|
clippy issues are addressed in #451 if you haven't already seen |
|
Yes I know. I need to wait until #451 is merged I guess. |
Nah. If you're finished with the PR I can just merge it, we know what the CI issue is and it's fixed elsewhere. |
|
Yes, it's finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After EIP-6780 the only accounts that can be selfdestructed are those created in the current transaction. On the other hand
apply_deltas_to_trie_statewas deleting from the next trie exactly the accounts that shouldn't be deleted after EIP-6780, making some blocks (20000275, 20000407, 20000724, 20000747, 20000750, and 20000785) fail. This PR fixes this issue.