Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preinitialize segments in all contexts #466

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

hratoanina
Copy link
Contributor

Changes the preinitialization constraints.
Now, the given segments (currently Code, TrieData, AccountsLinkedList and StorageLinkedList) are exempted from zero-initialization at any context, and not only at context 0 for the last three. This shouldn't be an issue since these three are never used by non-zero contexts.

This change adds a column, but allows to implement #441 completely with a total of only 30 Memory columns. This change also allow for one extra preinitialized segment for free, if we need it.

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 5, 2024
@Nashtare Nashtare added this to the continuations - Q3 2024 milestone Aug 6, 2024
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

evm_arithmetization/src/memory/memory_stark.rs Outdated Show resolved Hide resolved
@hratoanina hratoanina merged commit 21d22c6 into feat/continuations Aug 6, 2024
13 of 14 checks passed
@hratoanina hratoanina deleted the preinitialize_all_contexts branch August 6, 2024 16:08
Nashtare pushed a commit that referenced this pull request Aug 6, 2024
* Preinitialize segments in all contexts

* Apply comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants