Process state trie at the end #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
approved these changes
Aug 7, 2024
| @@ -139,7 +139,7 @@ pub(crate) fn prepare_interpreter<F: Field>( | |||
| account: &AccountRlp, | |||
| ) -> Result<()> { | |||
| let mpt_insert_state_trie = KERNEL.global_labels["mpt_insert_state_trie"]; | |||
| let check_state_trie = KERNEL.global_labels["check_state_trie"]; | |||
| let check_state_trie = KERNEL.global_labels["check_final_state_trie"]; | |||
There was a problem hiding this comment.
I don't think this is even being used? It was probably aimed at being the halt offset but is being overwritten in tests
There was a problem hiding this comment.
It is used as the initial offset for hashing, is it not? check_txn_trie was used as a halt offset, and I should indeed remove it now, though
4l0n50
approved these changes
Aug 8, 2024
What do you mean? We hash the state trie after the txn and receipt tries, now, don't we? |
|
I thought this PR was moving the hash of the initial txns and receipts tries to the end instead. I was misunderstanding #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #406 .
This PR changes the order at which the tries are processed: the initial and final state tries are processed and hashed after the transaction and receipt tries.