Check the global variable GLOBAL_METADATA_TRIE_DATA_SIZE
#483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
changed the title
GLOBAL_METADATA_TRIE_DARA_SIZEGLOBAL_METADATA_TRIE_DATA_SIZE
Nashtare
approved these changes
Aug 10, 2024
Nashtare
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Check trie data length * Change order of checks and improve comments * Apply comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473 .
This PR checks that the value stored in
GLOBAL_METADATA_TRIE_DARA_SIZEafter hashing the initial state trie is correct. Given that the initial trie is hashed and checked against the actual input hash, and that the final hash is constructed based on the initial trie, this should be enough to ensure soundness.Note that when "guessing" the initial state trie, we do not store the storage values in the trie anymore: the value is added (and the pointer overwritten) anyway in
mpt_set_payload.