Parallelize test_only segment simulation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: zero_bin
Nashtare
reviewed
Aug 14, 2024
zero_bin/ops/src/lib.rs
Outdated
Comment on lines
41
to
43
| let _ = SegmentDataIterator::<Field>::new(&inputs.0, Some(inputs.1)).collect::<Vec<_>>(); | ||
|
|
||
| Ok(()) |
There was a problem hiding this comment.
Suggested change
| let _ = SegmentDataIterator::<Field>::new(&inputs.0, Some(inputs.1)).collect::<Vec<_>>(); | |
| Ok(()) | |
| simulate_execution_all_segments::<Field>(&inputs.0, inputs.1) |
zero_bin/ops/src/lib.rs
Outdated
| @@ -25,6 +28,22 @@ use zero_bin_common::{debug_utils::save_inputs_to_disk, prover_state::p_state}; | |||
|
|
|||
| registry!(); | |||
|
|
|||
| #[cfg(feature = "test_only")] | |||
| #[derive(Deserialize, Serialize, RemoteExecute)] | |||
| pub struct BatchTestOnly {} | |||
There was a problem hiding this comment.
is there any reason why you're not using save_inputs_on_error field in this? Even though we technically can't log yet the inputs upon error because the iterator is panicking, we are aiming at changing this logic before the release, which would allow to save inputs even in testing mode.
There was a problem hiding this comment.
Yeah, I assumed we would add it when logging is available but we can have it there already. I also mimicked the error handling of the other operations for the future.
Nashtare
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Parallelize test_only segment simulation * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390.