Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign specific jobs to dedicated workers #564

Merged
merged 20 commits into from
Oct 16, 2024
Merged

Assign specific jobs to dedicated workers #564

merged 20 commits into from
Oct 16, 2024

Conversation

temaniarpit27
Copy link
Contributor

@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Aug 29, 2024
temaniarpit27
temaniarpit27 commented Aug 29, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
temaniarpit27
temaniarpit27 commented Aug 29, 2024
View reviewed changes
zero_bin/README.md Outdated Show resolved Hide resolved
@temaniarpit27 temaniarpit27 changed the title separate workers and jobs Assign specific jobs to dedicated workers Aug 29, 2024
@Nashtare Nashtare added this to the Performance Tuning milestone Sep 1, 2024
atanmarko
atanmarko reviewed Sep 2, 2024
View reviewed changes
zero_bin/tools/prove_rpc.sh Outdated Show resolved Hide resolved
zero_bin/tools/prove_rpc.sh Outdated Show resolved Hide resolved
zero_bin/leader/src/client.rs Outdated Show resolved Hide resolved
zero_bin/leader/src/http.rs Outdated Show resolved Hide resolved
@temaniarpit27 temaniarpit27 marked this pull request as ready for review September 3, 2024 13:14
muursh
muursh reviewed Sep 4, 2024
View reviewed changes
zero_bin/leader/src/cli.rs Outdated Show resolved Hide resolved
muursh
muursh reviewed Sep 4, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
muursh
muursh reviewed Sep 4, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
muursh
muursh reviewed Sep 4, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
muursh
muursh reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have we tested this? Have we tested edge cases? Error cases?

@temaniarpit27
Copy link
Contributor Author

How have we tested this? Have we tested edge cases? Error cases?

Tested this on single and multi node machine. Tried to cover all the cases. Not sure if you have anything specific in mind
Started multiple workers on multiple nodes. Let me know if you have anything in mind and see if i have covered that

atanmarko
atanmarko reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@atanmarko atanmarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes in the develop zero_bin project structure, will take a look one more time after rebase of this pr on top of develop

zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
zero_bin/common/src/proof_runtime.rs Outdated Show resolved Hide resolved
atanmarko
atanmarko reviewed Sep 19, 2024
View reviewed changes
zero/src/bin/leader.rs Outdated Show resolved Hide resolved
@0xaatif 0xaatif mentioned this pull request Sep 26, 2024
Closed
@temaniarpit27
Copy link
Contributor Author

@Nashtare final review from your side pls

Nashtare
Nashtare reviewed Oct 4, 2024
View reviewed changes
zero/src/bin/leader/cli.rs Show resolved Hide resolved
zero/src/prover.rs Outdated Show resolved Hide resolved
zero/src/prover.rs Show resolved Hide resolved
zero/src/bin/leader/cli.rs Show resolved Hide resolved
@temaniarpit27
Copy link
Contributor Author

@Nashtare final review pls

Nashtare
Nashtare approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

zero/src/bin/leader/cli.rs Outdated Show resolved Hide resolved
@muursh muursh merged commit 0ec9970 into develop Oct 16, 2024
21 checks passed
@muursh muursh deleted the arpit/507 branch October 16, 2024 09:13
Nashtare added a commit that referenced this pull request Oct 16, 2024
@temaniarpit27 @muursh @Nashtare
Assign specific jobs to dedicated workers (#564)
92a8578 
* separate workers

* fix review comments

* add worker run modes

* change default queue

* update cargo.lock

* fix review comments

* testing changes

* separate segment proof and segment agg proof

* review comments

* fix review comments

* Update zero/src/bin/leader/cli.rs

Co-authored-by: Robin Salen <[email protected]>

* update paladin version

---------

Co-authored-by: Ben <[email protected]>
Co-authored-by: Robin Salen <[email protected]>
einar-polygon pushed a commit that referenced this pull request Oct 29, 2024
@temaniarpit27 @muursh
@Nashtare @einar-polygon
Assign specific jobs to dedicated workers (#564)
a85080d 
* separate workers

* fix review comments

* add worker run modes

* change default queue

* update cargo.lock

* fix review comments

* testing changes

* separate segment proof and segment agg proof

* review comments

* fix review comments

* Update zero/src/bin/leader/cli.rs

Co-authored-by: Robin Salen <[email protected]>

* update paladin version

---------

Co-authored-by: Ben <[email protected]>
Co-authored-by: Robin Salen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovct leovct leovct left review comments

@Nashtare Nashtare Nashtare approved these changes

@atanmarko atanmarko atanmarko approved these changes

@muursh muursh muursh approved these changes

Assignees

@temaniarpit27 temaniarpit27

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Performance Tuning
Development

Successfully merging this pull request may close these issues.
5 participants
@temaniarpit27 @muursh @atanmarko @leovct @Nashtare