chore: remove cache dir sanity check

[leovct]

The code currently checks that the cache directory must end with the _circuit_cache suffix. I think this is too restrictive, any operator should be able to set whatever name they want. What do you guys think?

[atanmarko]

@leovct It is a bit restrictive because we introduced the clean operation. Random folders for the circuits together with the circuit cleanup are a recipe for disaster.

[leovct]

@leovct It is a bit restrictive because we introduced the clean operation. Random folders for the circuits together with the circuit cleanup are a recipe for disaster.

I'll add my answer here for future discussions (if any).

I agree that it is easier for developers but cleanup operations are typically not the core responsibility of the application. This falls under the principle of "do one thing and do it well".

Instead, we can reuse existing tools such as rm in utility scripts or we can write better docs to document cache locations and recommended cleanup practices for different platforms.

[Nashtare]

@leovct closing this for now, we may revisit tooling later on