Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to rpc and common modules #629

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Small fixes to rpc and common modules #629

merged 4 commits into from
Sep 16, 2024

Conversation

Nashtare
Copy link
Collaborator

  • the sanity check on the RPC fetch command prevents to fetch individual witnesses with same checkpoint (say witnesses for block 1 and 2, both targeting genesis as checkpoint, if the goal is to prove first b1 and pass it as --previous-proof argument of the second payload
  • --previous-proof expected a ProofWithPublicInputs but we always serialize elements as arrays

@Nashtare Nashtare added this to the x Misc. milestone Sep 15, 2024
@Nashtare Nashtare self-assigned this Sep 15, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 15, 2024
@Nashtare Nashtare merged commit e1def1b into develop Sep 16, 2024
17 checks passed
@Nashtare Nashtare deleted the misc/rpc branch September 16, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@muursh muursh muursh approved these changes

Assignees

@Nashtare Nashtare

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
x Misc.
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashtare @muursh @atanmarko