Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor proof types and method outputs #672

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Sep 30, 2024

Light tweak of AllRecursiveCircuits input/output types, and simplify distinct proof types. Also fix the outdated related doc.

@Nashtare Nashtare self-assigned this Sep 30, 2024
@github-actions github-actions bot added crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Sep 30, 2024
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, love simpler code :)

@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. ci labels Sep 30, 2024
@Nashtare Nashtare added this to the x Misc. milestone Oct 1, 2024
@Nashtare Nashtare merged commit 2439f87 into develop Oct 1, 2024
21 checks passed
@Nashtare Nashtare deleted the refactor/proof_outputs branch October 1, 2024 18:40
einar-polygon pushed a commit that referenced this pull request Oct 1, 2024
* Refactor proof types and method outputs

* Update doc and add CI lint (#673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants