Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block structlog retrieval #682

Merged
merged 10 commits into from
Oct 7, 2024
Merged

feat: block structlog retrieval #682

merged 10 commits into from
Oct 7, 2024

Conversation

atanmarko
Copy link
Member

Resolves #675

@atanmarko atanmarko self-assigned this Oct 1, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Oct 1, 2024
@atanmarko atanmarko added this to the Performance Tuning milestone Oct 1, 2024
@atanmarko atanmarko marked this pull request as ready for review October 1, 2024 16:43
@Nashtare Nashtare linked an issue Oct 1, 2024 that may be closed by this pull request
Replace debug_traceTransaction with block level calls where possible #675
Closed
@atanmarko
Copy link
Member Author

I'll remove server-fetched-structlogs. Then we will have:

  1. prover simulation
  2. client fectched structlogs (client gets raw structlogs from the server)
  3. server generated jumpdest table

Also, I'll remove create memory retrieval

@atanmarko atanmarko force-pushed the feat/block-structlogs-retrieval branch from 64c2237 to 6c3f6d0 Compare October 3, 2024 14:00
@atanmarko atanmarko force-pushed the feat/block-structlogs-retrieval branch from 6c3f6d0 to 8a74979 Compare October 3, 2024 14:59
@atanmarko atanmarko closed this Oct 3, 2024
@atanmarko atanmarko mentioned this pull request Oct 3, 2024
Closed
@atanmarko atanmarko reopened this Oct 3, 2024
@einar-polygon einar-polygon force-pushed the einar/prefetch_transaction_jumps/pr branch from 143f05d to 10b6a22 Compare October 3, 2024 21:02
@einar-polygon
Copy link
Contributor

It seems in my manual tests that native blocks always end up with jumpdest_table: null in the each transaction.

einar-polygon
einar-polygon approved these changes Oct 7, 2024
View reviewed changes
zero/src/rpc/jerigon.rs Outdated
};
let block_jumpdest_table_witnesses: Vec<Option<(JumpDestTableWitness, CodeDb)>> =
match jumpdest_src {
JumpdestSrc::ProverSimulation => Vec::new(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still have the same length to work in the prover.

@einar-polygon einar-polygon merged commit c11d17d into einar/prefetch_transaction_jumps/pr Oct 7, 2024
16 checks passed
@einar-polygon einar-polygon deleted the feat/block-structlogs-retrieval branch October 7, 2024 18:31
@atanmarko atanmarko mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einar-polygon einar-polygon einar-polygon approved these changes

@muursh muursh Awaiting requested review from muursh

@Nashtare Nashtare Awaiting requested review from Nashtare Nashtare is a code owner

Assignees

@atanmarko atanmarko

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Performance Tuning
Development

Successfully merging this pull request may close these issues.

Replace debug_traceTransaction with block level calls where possible
2 participants
@atanmarko @einar-polygon