Fix flaky test when DEBUG logging is enabled
#685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
wborgeaud,
muursh and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
0xaatif
approved these changes
Oct 1, 2024
| assert!(pc < KERNEL.code.len(), "Kernel PC is out of range: {}", pc); | ||
| let kernel_code = | ||
| &state.get_generation_state().memory.contexts[0].segments[Segment::Code.unscale()].content; | ||
| assert!(pc < kernel_code.len(), "Kernel PC is out of range: {}", pc); |
There was a problem hiding this comment.
nonblocking/education: I'd use assert2::assert! which would print the left and right values in the panic
muursh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_kernel_instructionsis a no-op inINFOmode (which is almost always used), but ensures (when running inDEBUG/TRACEmode) that the PC doesn't overflow the KERNEL size.As @0xaatif observed, this would cause the transient storage tests to fail (and only if run in
DEBUGor lower AND not isolated (otherwise the actual KERNEL static wouldn't be initialized).I've renamed the static variable in tests for clarity, and updated the check to retrieve the actual KERNEL code length from the memory instead. The overhead (if non-negligible), doesn't matter because we don't care so much about perfs with lower-level tracing anyway.
closes #664