Fix bytecode hashing for Type2 SMT #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: trace_decoder
No objection, @LindaGuiga has already run this past me :) |
LindaGuiga
approved these changes
Nov 7, 2024
| ), | ||
| Either::Right(type2world) => { | ||
| let batches = match start { | ||
| Either::Left((type1world, mut code)) => { |
There was a problem hiding this comment.
Should we change code to code_hash? start only returns code hashes, right?
There was a problem hiding this comment.
start is Either<World, Hash2Code>
* Move world into evm_arithmetization * Rustdoc
github-actions
bot
added
the
crate: evm_arithmetization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@0xaatif I took a shot at #779 because it was starting to collide with what I was doing on the type2 branch, please let me know what you think.
Also we'd like to move
Worldtrait and related structs toevm_arithmetizationinstead of thetrace_decoderfor easy reuse across case disjunction on the prover side. Do you have any objection? If not I could even add it to this PR.