feat: revamp zero prove function #793
Open
+179
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: zero_bin
Nashtare
reviewed
Nov 12, 2024
|
FYI I'm getting a ~5% improvement over a small sequence (3 blocks, 600 txns). |
atanmarko
force-pushed
the
feat/optimize-prove-task-dispatch
branch
from
94d1474
to
86d619a
Compare
LindaGuiga
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #627
Resolves #399
Resolves #403
Segmentation and task dispatch logic has been changed to handle proving of the individual segments of one batch on different workers. Aggregation is performed after the segments of one batch are proven (not waiting of segments of all the batches to be completed). Segments are generated sequentially and consumed immediately.