-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export annotation color as hex RGB code in JSON output #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! This makes sense. I have a couple of minor suggestions and one big one: I'd prefer to keep the colour strongly typed. (This will also make the type annotations easier to wrangle.) However, if you just want to make the minor fixes, I'll handle it myself later.
f666802
to
183f574
Compare
183f574
to
f2dc37f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, almost there. Thank you again!
I'm trying to figure out how to get github to run the tests, but I suspect one of the linters may add a little more busy-work for you when I do.
Edit: if you merge or rebase to my last changes on main branch, github should prompt us to run the tests.
I believe that everything is ok now! Let me know! |
Just a few nits but I can take care of them. |
Hi, again, thanks for all the work, it is great!!!
I added very simple piece of code to try to get color of the note. If it fails, nothing changes in the output.