Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page_label to JSON output #81

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Add page_label to JSON output #81

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
794f81f
feat(json): add `page_number` to output
linozen Aug 9, 2023
7490cde
fix: remove unneccessary `getattr`s and return directly
linozen Aug 10, 2023
d23f5bf
avoid changing name of existing json field
0xabu Aug 10, 2023
2779ba6
Merge branch 'main' into include-page-label-in-json
0xabu Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 10 additions & 21 deletions pdfannots/printer/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,30 +15,19 @@ def annot_to_dict(

result = {
"type": annot.subtype.name,
"page": annot.pos.page.pageno + 1,
"page_number": annot.pos.page.pageno + 1,
0xabu marked this conversation as resolved.
Show resolved Hide resolved
"page_label": annot.pos.page.label,
"start_xy": (annot.pos.x, annot.pos.y),
"prior_outline": getattr(doc.nearest_outline(annot.pos), 'title', None),
"text": annot.gettext(remove_hyphens),
"contents": annot.contents,
"author": annot.author,
"created": annot.created.strftime('%Y-%m-%dT%H:%M:%S') if annot.created else None,
"color": annot.color.ashex() if annot.color else None
}

outline = doc.nearest_outline(annot.pos)
if outline:
result["prior_outline"] = outline.title

if annot.text:
result['text'] = annot.gettext(remove_hyphens)

if annot.contents:
result['contents'] = annot.contents

if annot.author:
result['author'] = annot.author

if annot.created:
result['created'] = annot.created.strftime('%Y-%m-%dT%H:%M:%S')

if annot.color:
result['color'] = annot.color.ashex()

return result
# Remove keys with None values in nested dictionary and return
return {k: v for k, v in result.items() if v is not None}


class JsonPrinter(Printer):
Expand Down
Loading