[web] Cache/Manage pricings using global context #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect` This was to fix `Cannot update a component while rendering a different component` warning
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
junhoyeo
commented
Oct 12, 2022
Comment on lines
+16
to
+30
| const buildCacheStore = <T extends any>(prefix: string) => ({ | ||
| get: async (key: string): Promise<T | null> => { | ||
| const v = localStorage.getItem(prefix); | ||
| if (!v) { | ||
| return null; | ||
| } | ||
| return JSON.parse(v)[key] || null; | ||
| }, | ||
| set: async (key: string, value: T) => { | ||
| const v = localStorage.getItem(prefix); | ||
| const prev = !v ? {} : JSON.parse(v); | ||
| localStorage.setItem(prefix, JSON.stringify({ ...prev, [key]: value })); | ||
| }, | ||
| }); | ||
| const CacheStore = buildCacheStore('@pricings'); |
There was a problem hiding this comment.
TODO: Use IndexedDB with localForage
junhoyeo
added a commit
that referenced
this pull request
Oct 12, 2022
junhoyeo
added a commit
that referenced
this pull request
Oct 12, 2022
Rename file: `pricings` -> `useCachedPricings` Check server in `PricingsProvider` export type `getCachedPrice`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3