replace files, first commit #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completed the challenge: 5
I feel good about my code: 3
I'm feeling better about async since my last PR. I replaced all the files here with ones I wrote up myself following along with the video from Monday. Now that I know a little about the concepts behind MVC, this code looks very messy to me. But - I did get it to work, and it works well! I added some small things, shoddily sanitizing input, trying to prevent duplicates, a hidden input field holding the date, breaking up long strings.... I even added a cute little animated github corner that I saw in the wild.
Feeling better about the backend, it's slowly clicking. I have another repo with this code and I will be deploying it from there soon because I like how it turned out!