Fix script path and update to run with bash #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the path in `run-integration.sh` to use the correct relative path for `wait-for-it.sh`. By default, GitHub Actions uses the `sh` shell to execute scripts, which leads to syntax errors when running the `wait-for-it.sh` script because it contains Bash-specific syntax. Changed the execution of `wait-for-it.sh` to use `bash` instead of `sh` to avoid these syntax errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two improvements to the integration script run-integration.sh:
Corrected Script Path: The relative path to wait-for-it.sh has been updated to ensure it's referenced correctly within run-integration.sh.
Enforced Bash Execution: By default, GitHub Actions uses the sh shell, which can cause issues with script
wait-for-it.shdue to its Bash-specific syntax. This PR modifies the execution to use bash explicitly, preventing these syntax errors.This update ensures the integration script runs smoothly and avoids potential errors due to incorrect paths and shell interpretation.