-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to add images to QR Code #35
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for convert-to-qr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Nemesis-AS by adding the logo user is unable to scan it. |
I guess it might happen on the website because the Another fix can be tweaking the size of the logo to be even smaller |
|
I'll try tweaking the size of the image to see if it works then |
@Nemesis-AS any updates on this |
I have been unable to make any progress on this issue due to some urgent health issues, but will do it as soon as I can |
I have reduced the image size and it can easily be adjusted further. I tried a few qr codes and they all seem to work now. Let me know if any still fail |
Fixes #33
This PR adds the ability to add images to the QR Code. The ECC(Error Correction Code) is set automatically if an image is used.
This PR also removes the dependency
file-saver
, since the QR is manipulated on the client side and it is being downloaded using built-in browser methods, without the need for any dependencies.I also changed the default value of the download format from
JPEG
toPNG
sinceJPEG
s use lossy compression, which may affect the readability of the QR Code.QR_Code_Image_Demo.mp4
Any feedback is appreciated.