Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #69

Closed
wants to merge 3 commits into from
Closed

Docs #69

wants to merge 3 commits into from

Conversation

HardipinderS
Copy link

Hey, I just made a Pull Request!

Description

Makefile not working while running make livehtml and update on the docs for windows user

Motivation and Context

removing -p, as it is not working. Rather having it run directly as addition of --open-browser and --port fixes that

Have you tested this? If so, how?

ran make check

Checklist for PR author(s)

check it anyway

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Release note


@restyled-io restyled-io bot mentioned this pull request Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          17       17           
  Lines         638      638           
=======================================
  Hits          582      582           
  Misses         56       56           
Flag Coverage Δ
#unittests 91.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807cb56...81de9c2. Read the comment docs.

Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HardipinderS Thank you for taking out time and working on this project.
Please update these details a little bit. And if you have any doubts or queries please put it here will help you in solving them.

Thanks!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/Makefile Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Oct 5, 2020
Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HardipinderS Please work on forking section of the contributing guide first then we'll work on other sections.

Thanks for working on this!

@@ -163,16 +163,20 @@ like [pyenv-virtualenv](https://github.com/pyenv/pyenv-virtualenv),
[virtualenvwrapper](https://virtualenvwrapper.readthedocs.io/), and
[pyenv-virtualenvwrapper](https://github.com/pyenv/pyenv-virtualenvwrapper).

for git related issues refer to https://github.com/101Loop/APIManager-Flutter/blob/master/CONTRIBUTING.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HardipinderS I told you to take reference from that link and update this contributing guide on how to work on a forked version of this copy. So, please update the documentation guide how a user can contribute using a forked copy of this repo. We don't want users redirect to some other pages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what and how much exactly is to be referred and added in that part, so gave the link. i would request you to please look into that part, as I'm not that sure what exactly is required

@HardipinderS
Copy link
Author

won't be helping out any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile port command issue
2 participants