Generating headers for updated Execute command #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 31.56% 31.56%
=======================================
Files 8 8
Lines 5028 5028
Branches 542 542
=======================================
Hits 1587 1587
Misses 3366 3366
Partials 75 75 ☔ View full report in Codecov by Sentry. |
aentinger
requested changes
Mar 22, 2024
| @@ -5,9 +5,9 @@ | |||
| // Checking this file under version control is not recommended since metadata in this header will change for each | |||
| // build invocation. TODO: add --reproducible option to prevent any volatile metadata from being generated. | |||
| // | |||
| // Generator: nunavut-2.3.1 (serialization was enabled) | |||
There was a problem hiding this comment.
I'd say you are using quite an outdated nnvg version. Have you used the script supplied with this library?
There was a problem hiding this comment.
I used the update_cpp_header.sh file in the extras folder to generate
There was a problem hiding this comment.
How about you follow the instructions outlined here: https://github.com/107-systems/107-Arduino-Cyphal/blob/main/extras/script/README.md 🙏
aentinger
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to bring in ExecuteCommand.1.3.hpp to allow the use of an output field in the response