delete pretty trace #526
Merged
delete pretty trace #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
5 times, most recently
from
81a753c
to
1c3efb9
Compare
macklin-10x
force-pushed
the
macklin/clean-up-json-handling
branch
from
bb8d8d4
to
05db426
Compare
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
6b8c4a7
to
065fc85
Compare
macklin-10x
force-pushed
the
macklin/clean-up-json-handling
branch
from
4ead97e
to
79aecee
Compare
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
065fc85
to
69cfda3
Compare
macklin-10x
force-pushed
the
macklin/clean-up-json-handling
branch
from
79aecee
to
78dd975
Compare
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
31a5310
to
4251bfa
Compare
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
4251bfa
to
66bcc5f
Compare
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
66bcc5f
to
8bfb62c
Compare
Remove most all uses of pretty_trace. Remove more pretty_trace references and extern crate.
macklin-10x
force-pushed
the
macklin/delete-pretty-trace
branch
from
8bfb62c
to
97ca1e6
Compare
sreenathkrishnan
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes almost all of the pretty_trace code. Keeps a minimal panic handler hook that retains the "only one thread prints a stack trace" behavior to ensure we get something sensible if parallel code panics.
Stacked on another feature branch, will rebase once underlying branch merges.