remove internal run #554
remove internal run #554
Conversation
| // Fix IGHJ6. | ||
| if s == *"ATTACTACTACTACTACGGTATGGACGTCTGGGGCCAAGGGACCACGGTCACCGTCTCCTCA" | ||
| || s == *"ATTACTACTACTACTACTACATGGACGTCTGGGGCAAAGGGACCACGGTCACCGTCTCCTCA" |
There was a problem hiding this comment.
Hmm, this looks like potentially useful information about the reference buried here
There was a problem hiding this comment.
Can we archive this somewhere useful?
| // let mut config = HashMap::<String, String>::new(); | ||
| // let mut config_file = String::new(); | ||
| // for (key, value) in env::vars() { | ||
| // if key == "ENCLONE_CONFIG" { | ||
| // config_file = value.to_string(); | ||
| // if config_file.contains(',') { | ||
| // config_file = config_file.after(",").to_string(); | ||
| // } | ||
| // } | ||
| // } | ||
| // let _ = get_config(&config_file, &mut config); |
There was a problem hiding this comment.
No point keeping these lines?
There was a problem hiding this comment.
I opted to leave them in place; this entire executable will never run again, so we should either attempt to preserve it even in the face of refactoring, or go ahead and delete the entire thing.
| let mut remote_version_file = String::new(); | ||
| let mut remote_version = None; | ||
| if get_config(&config_file, &mut config) { | ||
| // if get_config(&config_file, &mut config) { | ||
| if false { |
There was a problem hiding this comment.
Should we remove this block too?
There was a problem hiding this comment.
Same thing here - we're probably never going to run this code again. If I start deleting code from here, it results in a cascade of "unused" vars.
Removes the internal_run flag and everything related to the config system.