Add new FatalFunc method to logger to override behavior for Fatal-level logging #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
force-pushed
the
daver/fatal-func
branch
2 times, most recently
from
341e685
to
8e1f087
Compare
This action is not allowed by our organization policy.
autarch
force-pushed
the
daver/fatal-func
branch
from
597867d
to
3324071
Compare
|
@autarch I removed myself from the reviewer since I am out till next Thursday. If it still needs review then, you can feel free to assign me as reviewer. Thanks! |
huan-Mongo
suggested changes
Feb 5, 2024
| @@ -1039,3 +1039,22 @@ func TestUnmarshalTextLevel(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestFatalFunc(t *testing.T) { | |||
There was a problem hiding this comment.
Could you also create a test case to make sure the fatal function can be passed down to the child logger created by a With() function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.