Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Facets] Incorrect link on filter blocks #3997

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR isolates the ternary operator, so PHP evaluates wp_is_block_theme() instead of '<p>' . wp_is_block_theme() (which would always return true.

Closes #3915

How to test the Change

Changelog Entry

Fixed - [Facets] Incorrect link on description when not using a block theme

Credits

Props @felipeelia @burhandodhy

Checklist:

@felipeelia felipeelia added this to the 5.2.0 milestone Nov 7, 2024
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felipeelia felipeelia merged commit 9769a5b into develop Nov 7, 2024
22 checks passed
@felipeelia felipeelia deleted the fix/issue-3915 branch November 7, 2024 14:58
@felipeelia felipeelia modified the milestones: 5.2.0, 5.1.4 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Incorrect link on filter blocks
2 participants