-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our blocks apiVersion
from 2 to 3
#4029
Conversation
…with the block editor
… related posts block. Fix finding the block tab
apiVersion
from 2 to 3apiVersion
from 2 to 3
@fabiankaegy @felipeelia I've updated all of the custom blocks from |
Thank you VERY much @dkotter. I'm merging this one now, as a new EP release is coming in the next few days and blocks will be thoroughly QA'd during that. |
🥳 Thanks so much for pushing this forward! |
Description of the Change
This is a follow on from the work started in #3863. We update the
apiVersion
in all of our blocks from 2 to 3, to allow the iframed editor to work correctly.This change causes some of our E2E tests to start failing, as we now need to interact with the block editor in an iframe state, something Cypress has issues with without changes. The following changes have been made:
getBlockEditor
command that will return the block editor iframegetIframe
function that thegetBlockEditor
command uses to properly get the block editor iframecloseBlockInserter
command to close the block inserter. In running tests locally, was seeing some issues where after adding a block, if the block inserter wasn't closed, Cypress was complaining about elements not being ready to interact withchromeWebSecurity
in our Cypress config tofalse
to allow Cypress to properly interact with iframeswait
commands to ensure things save properly. Not sure if that will be needed in our pipelines but running tests locally, sometimes things fire too quickly and changes we're making end up not getting saved (and causes tests to fail)Closes #3853
How to test the Change
Main thing to test here is that all blocks still work as expected.
Also ensure all E2E tests pass.
Changelog Entry
Credits
Props @dkotter, @JakePT
Checklist: