Replace `TextControl` with `SearchControl` in `ContentSearch` Component #280

psorensen · 2024-01-17T05:18:29Z

Description of the Change

How to test the Change

Insert Content Picker or Post Picker block in /example
Confirm search component is used and block is operating normally

Changelog Entry

Replaces TextControl with SearchControl in 'content-search' component
Adds Content Picker block to test and demonstrate content-picker component
Updates documentation to include new prop and updates demo gif

Credits

Props @psorensen

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

github-actions · 2024-01-17T05:20:06Z

Size Change: +161 B (0%)

Total Size: 65.4 kB

Filename	Size	Change
`dist/index.js`	65.4 kB	+161 B (0%)

_{compressed-size-action}

cypress · 2024-01-17T05:22:32Z

5 failed tests on run #692 ↗︎

5	1	0	0	0

Details:

git commit remove manual border
Project: 10up Block Components	Commit: `81a8919dab`
Status: Failed	Duration: 01:23 💡
Started: Jan 18, 2024 7:34 PM	Ended: Jan 18, 2024 7:36 PM

IconPicker.spec.js • 1 failed test

View Output Video

Test		Artifacts
IconPicker > allows the user to use the post picker to change an icon and displays it		`Screenshots` `Video`

Image.spec.js • 1 failed test

View Output Video

Test		Artifacts
Image > allows the user to pick an image from the media library and displays it inline		`Screenshots` `Video`

Link.spec.js • 1 failed test

View Output Video

Test		Artifacts
Link > allows the editor to pick a link directly inline		`Screenshots` `Video`

Repeater.spec.js • 1 failed test

View Output Video

Test		Artifacts
Repeater > Adding Repeater field and saving it.		`Screenshots` `Video`

registerBlockExtension.spec.js • 1 failed test

View Output Video

Test		Artifacts
registerBlockExtension > ensure the new setting shows up and doesn't cause deprecation errors		`Screenshots` `Video`

Review all test suite changes for PR #280 ↗︎

github-actions · 2024-01-17T08:34:47Z

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-280

Antonio-Laguna

This LGTM! Thanks @psorensen !

Will let @fabiankaegy chime in since he might more opinion here!

fabiankaegy

Thanks for making this update :)

I've left some suggestions for what I personally think looks better and feels more native in the editor.

Before	After

components/content-search/index.js

fabiankaegy · 2024-01-18T10:36:30Z

components/content-search/index.js

@@ -357,6 +359,8 @@ const ContentSearch = ({
 					onBlur={() => {
 						setIsFocused(false);
 					}}
+					size="compact"
+					style={{ border: '1px solid rgb(30, 30, 30)' }}


I'm not sure we need this manual border. With the greater space it has this should look better without I think

My concern here is that I cannot see the border of the input at all - maybe it's my eyes, but I don't even realize it's a search input without the border

Ah - there was something with my monitor - probably a high contrast setting (ironic enough) that was preventing me from seeing the gray background of the input. I've removed the manual style.

Co-authored-by: Fabian Kägy <[email protected]>

replaces TextControl with SearchControl

e21d957

psorensen self-assigned this Jan 17, 2024

psorensen had a problem deploying to testing January 17, 2024 05:18 — with GitHub Actions Error

psorensen marked this pull request as draft January 17, 2024 05:18

adds block to demonstrate content-picker block

0c561eb

psorensen temporarily deployed to testing January 17, 2024 05:20 — with GitHub Actions Inactive

psorensen added 3 commits January 17, 2024 20:35

linting

374487e

adds searchControl prop for hiding label

2798d1c

updates demo gif

c99cbe1

psorensen had a problem deploying to testing January 18, 2024 05:12 — with GitHub Actions Error

psorensen changed the title ~~replaces TextControl with SearchControl~~ replace TextControl with SearchControl in content-search Jan 18, 2024

psorensen requested review from fabiankaegy and Antonio-Laguna January 18, 2024 05:20

psorensen marked this pull request as ready for review January 18, 2024 05:20

Antonio-Laguna approved these changes Jan 18, 2024

View reviewed changes

fabiankaegy requested changes Jan 18, 2024

View reviewed changes

fabiankaegy added [Type] Enhancement New feature or request [Component] Content Picker labels Jan 18, 2024

fabiankaegy changed the title ~~replace TextControl with SearchControl in content-search~~ Replace TextControl with SearchControl in ContentSearch Component Jan 18, 2024

Update components/content-search/index.js

e0f1216

Co-authored-by: Fabian Kägy <[email protected]>

psorensen had a problem deploying to testing January 18, 2024 16:29 — with GitHub Actions Error

remove compact size

8e7bab9

psorensen had a problem deploying to testing January 18, 2024 16:33 — with GitHub Actions Error

update testing package

18f82a0

psorensen had a problem deploying to testing January 18, 2024 17:13 — with GitHub Actions Error

git commit remove manual border

81a8919

psorensen had a problem deploying to testing January 18, 2024 19:31 — with GitHub Actions Error

psorensen requested a review from fabiankaegy January 18, 2024 19:32

psorensen mentioned this pull request Jan 19, 2024

Use SearchControl component from WordPress Core psorensen/curated-query-loop#2

Closed

fabiankaegy approved these changes Jan 23, 2024

View reviewed changes

fabiankaegy merged commit 1189822 into develop Jan 23, 2024
3 of 6 checks passed

fabiankaegy deleted the feature/content-search-with-searchcontrol-component branch January 23, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `TextControl` with `SearchControl` in `ContentSearch` Component #280

Replace `TextControl` with `SearchControl` in `ContentSearch` Component #280

psorensen commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024 •

edited

Loading

cypress bot commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024

Antonio-Laguna left a comment

fabiankaegy left a comment

fabiankaegy Jan 18, 2024

psorensen Jan 18, 2024

psorensen Jan 18, 2024

Replace TextControl with SearchControl in ContentSearch Component #280

Replace TextControl with SearchControl in ContentSearch Component #280

Conversation

psorensen commented Jan 17, 2024 • edited Loading

Description of the Change

How to test the Change

Changelog Entry

Credits

Checklist:

github-actions bot commented Jan 17, 2024 • edited Loading

cypress bot commented Jan 17, 2024 • edited Loading

5 failed tests on run #692 ↗︎

Review all test suite changes for PR #280 ↗︎

github-actions bot commented Jan 17, 2024

Antonio-Laguna left a comment

Choose a reason for hiding this comment

fabiankaegy left a comment

Choose a reason for hiding this comment

fabiankaegy Jan 18, 2024

Choose a reason for hiding this comment

psorensen Jan 18, 2024

Choose a reason for hiding this comment

psorensen Jan 18, 2024

Choose a reason for hiding this comment

Replace `TextControl` with `SearchControl` in `ContentSearch` Component #280

Replace `TextControl` with `SearchControl` in `ContentSearch` Component #280

psorensen commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024 •

edited

Loading

cypress bot commented Jan 17, 2024 •

edited

Loading