Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: Add TS support for Optional component #298

Merged
merged 9 commits into from
Mar 11, 2024
Merged

upkeep: Add TS support for Optional component #298

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3485d0
move Optional component to TS
Sidsector9 Mar 1, 2024
8b862f4
eslint fix
Sidsector9 Mar 1, 2024
1cab61d
remove proptypes
Sidsector9 Mar 1, 2024
229c1f3
add doc
Sidsector9 Mar 1, 2024
3630823
Update components/optional/index.ts
Sidsector9 Mar 3, 2024
60b34bf
Merge branch 'upkeep/component-optional' of github.com:10up/block-com…
Sidsector9 Mar 3, 2024
a7391dc
Merge branch 'develop' into upkeep/component-optional
Sidsector9 Mar 3, 2024
dc65fef
remove default props
Sidsector9 Mar 11, 2024
355e598
Merge branch 'upkeep/component-optional' of github.com:10up/block-com…
Sidsector9 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion components/optional/index.js → components/optional/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
import PropTypes from 'prop-types';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that as part of converting something to TypeScript it makes sense to get rid of all the PropTypes stuff.

import { useBlockEditContext } from '@wordpress/block-editor';

export const Optional = ({ value, children }) => {
interface OptionalProps {
value?: string | number | boolean;
children: React.ReactNode;
}

export const Optional: React.FC<OptionalProps> = ({
value,
Sidsector9 marked this conversation as resolved.
Show resolved Hide resolved
children,
}): boolean | React.ReactNode => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need / want to explicitly type the return type of every function. If something can be inferred I would rather just leave it up to the compiler

const { isSelected } = useBlockEditContext();
return (isSelected || !!value) && children;
};
Expand Down
Loading