Merge pull request #365 from jonnynews/fix/php-82

Change null to '' for better support with PHP 8.2 and WP 6.2+
10up · Feb 5, 2024 · 1d8f12a · 1d8f12a
2 parents 695a3a1 + a179a7f
commit 1d8f12a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/includes/admin/class-bc-admin-menu.php b/includes/admin/class-bc-admin-menu.php
@@ -31,8 +31,8 @@ public function register_admin_menu() {
 			add_submenu_page( 'brightcove', esc_html__( 'Brightcove Labels', 'brightcove' ), esc_html__( 'Labels', 'brightcove' ), 'manage_options', 'brightcove-labels', array( $this, 'render_labels_page' ) );
 
 			// These have no parent menu slug so they don't appear in the menu
-			add_submenu_page( null, esc_html__( 'Add Source', 'brightcove' ), esc_html__( 'Add Source', 'brightcove' ), 'manage_options', 'page-brightcove-edit-source', array( $this, 'render_edit_source_page' ) );
-			add_submenu_page( null, esc_html__( 'Edit Label', 'brightcove' ), esc_html__( 'Edit Label', 'brightcove' ), 'manage_options', 'page-brightcove-edit-label', array( $this, 'render_edit_label_page' ) );
+			add_submenu_page( '', esc_html__( 'Add Source', 'brightcove' ), esc_html__( 'Add Source', 'brightcove' ), 'manage_options', 'page-brightcove-edit-source', array( $this, 'render_edit_source_page' ) );
+			add_submenu_page( '', esc_html__( 'Edit Label', 'brightcove' ), esc_html__( 'Edit Label', 'brightcove' ), 'manage_options', 'page-brightcove-edit-label', array( $this, 'render_edit_label_page' ) );
 
 			remove_submenu_page( 'brightcove', 'brightcove' );
 		}