Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update call fail when labels are empty #381

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix: Update call fail when labels are empty #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76fcb02
Fix: Update call fail when labels are empty
burhandodhy Mar 26, 2024
2ecc6c3
Add additional check on server end
burhandodhy Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion assets/js/src/views/video-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ var VideoEditView = BrightcoveView.extend({
this.model.set('captions', captions);

// Labels
const labels = this.$el.find('.bc-labels-value').val()?.split(',') || [];
let labels = this.$el.find('.bc-labels-value').val();
labels = labels !== '' ? labels.split(',') : [];
this.model.set('labels', labels);

// Custom fields
Expand Down
2 changes: 1 addition & 1 deletion includes/admin/api/class-bc-admin-media-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function bc_ajax_update_video_or_playlist() {

$labels = array();
if ( isset( $_POST['labels'] ) ) {
foreach ( $_POST['labels'] as $label ) {
foreach ( array_filter( $_POST['labels'] ) as $label ) {
$labels[] = sanitize_text_field( $label );
}
}
Expand Down
Loading