Merge pull request #142 from 10up/fix/issue-141-duplicate-ids

adds menu ID to submenu ID to prevent duplicate IDs
10up · Apr 17, 2023 · 8985bca · 8985bca
2 parents 0ef0f4a + 793f58a
commit 8985bca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/navigation/package.json b/packages/navigation/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@10up/component-navigation",
-  "version": "2.1.4",
+  "version": "2.1.5",
   "author": "10up",
   "description": "Accessible navigation component.",
   "main": "dist/index.js",

diff --git a/packages/navigation/src/navigation.js b/packages/navigation/src/navigation.js
@@ -200,9 +200,10 @@ export default class Navigation {
 	 * Adds JS classes and initial AIRA attributes.
 	 */
 	setupSubMenus() {
+		const id = this.$menu.getAttribute('id') ?? '';
 		this.$submenus.forEach(($submenu, index) => {
 			const $anchor = $submenu.previousElementSibling;
-			const submenuID = `tenUp-submenu-${index}`;
+			const submenuID = `tenUp-submenu-${id}-${index}`;
 
 			$submenu.setAttribute('id', submenuID);