Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow react rules of hooks #1228

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Follow react rules of hooks #1228

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d520ab4
Follow react rules of hooks
kirtangajjar Jun 15, 2024
9620a3e
Merge branch 'develop' into fix/sync-patterns-error-2
peterwilsoncc Jun 17, 2024
fb3028b
Merge branch 'develop' into fix/sync-patterns-error-2
Sidsector9 Jul 14, 2024
d0bf34a
fix documentation
Sidsector9 Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions assets/js/gutenberg-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,34 @@ const DistributorIcon = () => (
* Add the Distributor panel to Gutenberg
*/
const DistributorPlugin = () => {
// Ensure the user has proper permissions
if (
dtGutenberg.noPermissions &&
1 === parseInt( dtGutenberg.noPermissions )
) {
return null;
}

// eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed.
// eslint-disable-next-line no-shadow

const postType = useSelect( ( select ) =>
select( 'core/editor' ).getCurrentPostType()
);

// eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed.
// eslint-disable-next-line no-shadow -- permission checks are needed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line no-shadow -- permission checks are needed.
// eslint-disable-next-line no-shadow

const postStatus = useSelect( ( select ) =>
select( 'core/editor' ).getCurrentPostAttribute( 'status' )
);

// eslint-disable-next-line @wordpress/no-unused-vars-before-return
const distributorTopMenu = document.querySelector(
'#wp-admin-bar-distributor'
);

// eslint-disable-next-line no-shadow -- permission checks are needed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line no-shadow -- permission checks are needed.
// eslint-disable-next-line no-shadow

const post = useSelect( ( select ) =>
select( 'core/editor' ).getCurrentPost()
);

// Ensure the user has proper permissions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well fix the comment style while we're changing this code.

Suggested change
// Ensure the user has proper permissions
// Ensure the user has proper permissions.

if (
dtGutenberg.noPermissions &&
1 === parseInt( dtGutenberg.noPermissions )
) {
return null;
}

// Ensure we are on a supported post type
if (
dtGutenberg.supportedPostTypes &&
Expand All @@ -179,14 +189,6 @@ const DistributorPlugin = () => {
return null;
}

const distributorTopMenu = document.querySelector(
'#wp-admin-bar-distributor'
);

// eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed.
const post = useSelect( ( select ) =>
select( 'core/editor' ).getCurrentPost()
);
// Make the post title and status available to the top menu.
dt.postTitle = post.title;
dt.postStatus = post.status;
Expand Down
Loading