Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect featured image #1254

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix incorrect featured image #1254

merged 3 commits into from
Aug 15, 2024

Conversation

phpbits
Copy link
Contributor

@phpbits phpbits commented Jul 26, 2024

Description of the Change

This PR fixes the issue with the incorrect featured image when pushing a post.

Closes #1198

How to test the Change

  • Create a post and insert at least one image in the content
  • Assign a featured image different from the one you've inserted
  • Publish the post
  • Distribute to any site
  • Check if the distributed post has the correct image

Changelog Entry

Fixed - Bug fix

Credits

Props @phpbits

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@phpbits phpbits requested a review from a team as a code owner July 26, 2024 16:27
@phpbits phpbits requested review from peterwilsoncc and removed request for a team July 26, 2024 16:27
@github-actions github-actions bot added this to the 2.1.0 milestone Jul 26, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 26, 2024
@jeffpaul jeffpaul requested a review from Sidsector9 July 29, 2024 16:50
@Sidsector9
Copy link
Member

@phpbits I'm unable to test the PR because I'm unable to reproduce the issue on the develop branch.

Please watch the video below:

pull-1254.mov

@phpbits
Copy link
Contributor Author

phpbits commented Jul 30, 2024

@Sidsector9 Try unchecking the "Draft" option. Let me know how it goes. Thanks!

Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several attempts to reproduce the issue in the same MU network but was unsuccessful in the develop branch. After internal discussion, I am approving this PR. The changes look good and have tested well in both internal (same MU network) and external connections.

@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
@dkotter dkotter merged commit 1f82529 into develop Aug 15, 2024
10 of 18 checks passed
@dkotter dkotter deleted the fix/incorrect-featured-image branch August 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured Image Not Pulling
4 participants