Align show-connections-amp template with show-connections #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rgiosan
requested review from
Sidsector9,
dkotter,
jeffpaul and
a team
and removed request for
a team
dkotter
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
On 9to5Toys, which uses an AMP theme, when the client selects a site for post distribution, the site does not appear in the list of selected connections. The console.log displays the JavaScript error: "Uncaught TypeError: Cannot set properties of null (setting 'textContent')." This issue stems from a change outlined here 3f6b39e, which was not updated in the AMP template.
How to test the Change
Changelog Entry
Credits
Props @s3rgiosan
Checklist: